-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constants added for searchbackpressure rca reader to consume searchbackpressure metrics in shared folder #34
Changes from all commits
c25f161
cb1fe3e
7ffdb89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -943,7 +943,9 @@ public enum SearchBackPressureStatsValue implements MetricValue { | |
SearchBackPressureStatsValue.Constants.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_MODE), | ||
SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS( | ||
SearchBackPressureStatsValue.Constants | ||
.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS); | ||
.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS), | ||
SEARCHBP_TABLE_NAME(SearchBackPressureStatsValue.Constants.SEARCHBP_TABLE_NAME), | ||
SEARCHBP_TYPE_DIM(SearchBackPressureStatsValue.Constants.SEARCHBP_TYPE_DIM); | ||
|
||
private final String value; | ||
|
||
|
@@ -1037,6 +1039,16 @@ public static class Constants { | |
public static final String SEARCHBP_SEARCH_BACK_PRESSURE_STATS_MODE = "mode"; | ||
public static final String SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS = | ||
"searchTaskStats"; | ||
|
||
|
||
/** | ||
* Add SEARCHBP_TABLE_NAME for searchbackpressureRCA to find the corresponding table | ||
*/ | ||
public static final String SEARCHBP_TABLE_NAME = "Searchbp_Stats"; | ||
/** | ||
* Add SEARCHBP_TYPE_DIM for searchbackpressureRCA to find the cell value for each stats type | ||
*/ | ||
public static final String SEARCHBP_TYPE_DIM = "SearchBackPressureStats"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add some details about the purpose of this ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolved in latest commit.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @CoderJeffrey can you plz add comments for 2 constants separately?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Latest commit added comments for 2 constants separately. Resolved. |
||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we replicating this information ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS);
change to.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS),
because it is not the final constants in the listSEARCHBP_TABLE_NAME(SearchBackPressureStatsValue.Constants.SEARCHBP_TABLE_NAME),
use this for easier access and consistent coding style.