Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Applying Google Code Format for ppl files #12 #1972

Merged

Conversation

MitchellGale
Copy link
Contributor

Description

Applies spotless for ppl directory in project. Sets checkstyle to not fail on failure for ppl directory.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <[email protected]>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1972 (1128c4d) into main (5381a6f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1972   +/-   ##
=========================================
  Coverage     97.51%   97.51%           
  Complexity     4656     4656           
=========================================
  Files           408      408           
  Lines         11930    11932    +2     
  Branches        829      829           
=========================================
+ Hits          11634    11636    +2     
  Misses          289      289           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...opensearch/sql/ppl/parser/AstStatementBuilder.java 83.33% <ø> (ø)
...opensearch/sql/ppl/utils/UnresolvedPlanHelper.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/ppl/PPLService.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/ppl/antlr/PPLSyntaxParser.java 100.00% <100.00%> (ø)
...org/opensearch/sql/ppl/domain/PPLQueryRequest.java 100.00% <100.00%> (ø)
...rg/opensearch/sql/ppl/domain/PPLQueryResponse.java 100.00% <100.00%> (ø)
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <100.00%> (ø)
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/ppl/utils/ArgumentFactory.java 100.00% <100.00%> (ø)
...ensearch/sql/ppl/utils/PPLQueryDataAnonymizer.java 100.00% <100.00%> (ø)

Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 16, 2023
…uilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit e8e94d0 into opensearch-project:main Aug 16, 2023
15 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the integ/sl_GoogleJavaFormat12 branch August 16, 2023 20:33
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…project#1972)

* Spotless apply on PPL (#339)

Signed-off-by: Mitchell Gale <[email protected]>

* Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…project#1972)

* Spotless apply on PPL (#339)

Signed-off-by: Mitchell Gale <[email protected]>

* Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…project#1972)

* Spotless apply on PPL (#339)

Signed-off-by: Mitchell Gale <[email protected]>

* Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants