Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spotless stylecheck in sql project #1101

Closed
penghuo opened this issue Nov 23, 2022 · 3 comments
Closed

Use spotless stylecheck in sql project #1101

penghuo opened this issue Nov 23, 2022 · 3 comments
Labels
maintenance Improves code quality, but not the product

Comments

@penghuo
Copy link
Collaborator

penghuo commented Nov 23, 2022

  1. Use spotless stylecheck. Spotless checkstyle plugin has the spotlessApply task which could automatically format code.
  2. Use google code format.
@penghuo penghuo added enhancement New feature or request untriaged maintenance Improves code quality, but not the product and removed enhancement New feature or request untriaged labels Nov 23, 2022
@penghuo
Copy link
Collaborator Author

penghuo commented Nov 23, 2022

because enforce stylecheck will change too many files, we should find proper time to apply this change. example change. penghuo@404265a

This was referenced Aug 14, 2023
@MitchellGale
Copy link
Contributor

Spotless does not format well on antlr files. #2017 adds some of the spotless antlr changes that make improvements for the project, but leaves some changes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Development

No branches or pull requests

3 participants