Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Applying Google Code Format for several directories #15 #1975

Merged

Conversation

MitchellGale
Copy link
Contributor

Description

Applies spotless for several directories in project. Sets checkstyle to not fail on failure for several directories.

Note: adds directories that have no java in them. No negative impact, later will replace something that include entire project.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Spotless apply on 'datasources/**/*.java',
                                      'core/**/*.java',
                                      'docs/**/*.java',
                                      'doctest/**/*.java',
                                      'relase-notes/**/*.java',
                                      'spark/**/*.java'

Signed-off-by: Mitchell Gale <[email protected]>

* Added more directories to build.gradle

Signed-off-by: Mitchell Gale <[email protected]>

* spotless apply for plugin.

Signed-off-by: Mitchell Gale <[email protected]>

* Adding checkstyle ignorefailures.

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
pjfitzgibbons
pjfitzgibbons previously approved these changes Aug 16, 2023
Signed-off-by: Mitchell Gale <[email protected]>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1975 (093bb95) into main (549d0a0) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1975   +/-   ##
=========================================
  Coverage     97.52%   97.52%           
+ Complexity     4657     4655    -2     
=========================================
  Files           408      408           
  Lines         11952    11952           
  Branches        829      829           
=========================================
  Hits          11656    11656           
  Misses          289      289           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...nctions/scan/SparkSqlFunctionTableScanBuilder.java 100.00% <ø> (ø)
...a/org/opensearch/sql/spark/helper/FlintHelper.java 100.00% <ø> (ø)
...va/org/opensearch/sql/spark/storage/SparkScan.java 100.00% <ø> (ø)
...org/opensearch/sql/spark/client/EmrClientImpl.java 100.00% <100.00%> (ø)
...implementation/SparkSqlFunctionImplementation.java 100.00% <100.00%> (ø)
...ctions/resolver/SparkSqlTableFunctionResolver.java 100.00% <100.00%> (ø)
...esponse/DefaultSparkSqlFunctionResponseHandle.java 100.00% <100.00%> (ø)
...ctions/scan/SparkSqlFunctionTableScanOperator.java 100.00% <100.00%> (ø)
...g/opensearch/sql/spark/response/SparkResponse.java 100.00% <100.00%> (ø)
...ensearch/sql/spark/storage/SparkStorageEngine.java 100.00% <100.00%> (ø)
... and 2 more

... and 10 files with indirect coverage changes

Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 17, 2023
build.gradle Outdated Show resolved Hide resolved
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 17, 2023
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Mitchell Gale <[email protected]>
@GumpacG GumpacG merged commit bb3c340 into opensearch-project:main Aug 17, 2023
14 of 15 checks passed
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…pensearch-project#1975)

* Dev/sl google java format15 (#341)

* Spotless apply on 'datasources/**/*.java',
                                      'core/**/*.java',
                                      'docs/**/*.java',
                                      'doctest/**/*.java',
                                      'relase-notes/**/*.java',
                                      'spark/**/*.java'

Signed-off-by: Mitchell Gale <[email protected]>

* Added more directories to build.gradle

Signed-off-by: Mitchell Gale <[email protected]>

* spotless apply for plugin.

Signed-off-by: Mitchell Gale <[email protected]>

* Adding checkstyle ignorefailures.

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>

* added missing semi colon.

Signed-off-by: Mitchell Gale <[email protected]>

* Update build.gradle

Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

* Update build.gradle

Signed-off-by: Mitchell Gale <[email protected]>

* Update build.gradle

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants