[Spotless] Applying Google Code Format for legacy directory (pt 1/4) #19 #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1988 +/- ##
=========================================
Coverage 97.33% 97.33%
Complexity 4657 4657
=========================================
Files 408 408
Lines 12097 12097
Branches 829 829
=========================================
Hits 11775 11775
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
force-pushed
the
testing_aug17_s
branch
from
5ad54c4
to
320da40
Compare
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
GumpacG
reviewed
Aug 18, 2023
Signed-off-by: Mitchell Gale <[email protected]>
GumpacG
approved these changes
Aug 18, 2023
Yury-Fridlyand
approved these changes
Aug 19, 2023
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
(opensearch-project#1988) * spotless apply for OpenSearch P1. Signed-off-by: Mitchell Gale <[email protected]> * Manual spotless changes Signed-off-by: Mitchell Gale <[email protected]> * spotless apply for OpenSearch P2. Signed-off-by: Mitchell Gale <[email protected]> * 90 files checked after spotless apply for legacy Signed-off-by: Mitchell Gale <[email protected]> * Added checkstyle ignore failures to legacy Signed-off-by: Mitchell Gale <[email protected]> * Fixed comma issue Signed-off-by: Mitchell Gale <[email protected]> * Spotless apply Signed-off-by: Mitchell Gale <[email protected]> * Revert build.gradle Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies spotless for part of legacy directory in project. Sets checkstyle to not fail on failure for legacy directory.
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.