[rhaiis] Add missing workload profiles 5-7 and composite benchmark presets - #181
[rhaiis] Add missing workload profiles 5-7 and composite benchmark presets#181hp2419 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…esets Sync workload profiles from model-furnace that were missing in forge: - profile5: 100k/1k ultra-long context - profile6: multi-turn with prefix caching (5 turns) - profile7: heavy heterogeneous (prompt 50-30k, output 20-8k) Add composite benchmark presets for common test matrices: - benchmark-standard (profile1+2) - benchmark-long-context (profile4+5) - benchmark-full-sweep (all profiles) - benchmark-multi-turn (profile6) - benchmark-heterogeneous (profile7)
e61cc2b to
c40686e
Compare
|
cc @Harshith-umesh @albertoperdomo2 — could you review this when you get a chance? |
| benchmark-multi-turn: | ||
| extends: | ||
| - benchmark | ||
| tests.rhaiis.workload_key: profile6 | ||
|
|
||
| benchmark-heterogeneous: | ||
| extends: | ||
| - benchmark | ||
| tests.rhaiis.workload_key: profile7 |
There was a problem hiding this comment.
random question from a rhaiis-outsider: is there no way to give a meaningful name to the profiles?
profile6 seems to be multi-turn and profile7 is heterogeneous,
but are these number profiles mandatory? 🤔
There was a problem hiding this comment.
Great question! The numbered names (profile1–7) are inherited from model-furnace, where they're used in regression comparison (PROFILE_MAP), payload pattern matching
(_PROFILE_PATTERNS), and benchmark launch scripts. Renaming them in forge would break the alignment between the two systems and make cross-system result comparisons harder.
That said, the preset layer is exactly where we add meaningful names. The workload keys stay as profile1–profile7, but users interact through presets like benchmark-multi-turn,
benchmark-heterogeneous, benchmark-long-context, etc.
We could also consider adding aliases in workloads.yaml (e.g. multi-turn pointing to the same config as profile6) if we want meaningful names at the workload level too, without breaking the numbered convention.
|
@hp2419 I'm closing this PR since @sacherukuri has already added this functionality in this PR: #173 a few days ago. |
Summary
Test plan