-
Notifications
You must be signed in to change notification settings - Fork 14
[rhaiis] Add missing workload profiles 5-7 and composite benchmark presets #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hp2419
wants to merge
1
commit into
openshift-psap:main
from
hp2419:rhaiis-add-missing-workload-profiles
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random question from a rhaiis-outsider: is there no way to give a meaningful name to the profiles?
profile6seems to bemulti-turnandprofile7isheterogeneous,but are these number profiles mandatory? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! The numbered names (profile1–7) are inherited from model-furnace, where they're used in regression comparison (
PROFILE_MAP), payload pattern matching(
_PROFILE_PATTERNS), and benchmark launch scripts. Renaming them in forge would break the alignment between the two systems and make cross-system result comparisons harder.That said, the
preset layeris exactly where we add meaningful names. The workload keys stay asprofile1–profile7, but users interact through presets likebenchmark-multi-turn,benchmark-heterogeneous,benchmark-long-context, etc.We could also consider adding aliases in
workloads.yaml(e.g.multi-turnpointing to the same config asprofile6) if we want meaningful names at the workload level too, without breaking the numbered convention.