fournos: set a 24h timeout for the task completion

[kpouget]

PipelineRun default is 1h:

  spec:
    timeouts:
      pipeline: 1h0m0s

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift-psap_forge/129/pull-ci-openshift-psap-forge-main-fournos/2077705564653096960/artifacts/fournos/fournos/artifacts/001__submit_and_wait/artifacts/pipelinerun.yaml

we'll make that configurable from the fjob later

Summary by CodeRabbit

• New Features
  • Added configurable timeouts for pipeline runs, including separate limits for the overall pipeline, tasks, and finalization steps.
  • Added default timeout values and support for duration formats such as 25h0m0s and 90m.

[coderabbitai]

Warning

Review limit reached

@kpouget, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 23c50125-730d-4c58-8d9b-ef549b7babec

📥 Commits

Reviewing files that changed from the base of the PR and between 5851c8a and 500c6c3.

📒 Files selected for processing (2)

• fournos/core/tekton.py
• fournos/settings.py

📝 Walkthrough

Walkthrough

PipelineRun generation now includes configurable pipeline, task, and finally timeout values. The settings model supplies defaults and descriptions for the three duration parameters.

Changes

Pipeline timeout configuration

Layer / File(s)	Summary
Define and apply PipelineRun timeouts fournos/settings.py, fournos/core/tekton.py	Settings adds three duration fields, and TektonClient.create_pipeline_run places their values in the generated Tekton timeouts specification.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: adding a 24h timeout for task completion in Fournos.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kpouget]

/test deploy-fournos-wip

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@fournos/settings.py`:
- Around line 29-31: Update the description for the pipeline_tasks_timeout Field
to state that it represents the cumulative timeout across non-finally tasks in
PipelineRun, rather than the default timeout for each individual task. Preserve
the existing default value and examples.
- Around line 25-36: Add settings-level validation for pipeline_timeout,
pipeline_tasks_timeout, and pipeline_finally_timeout using the existing settings
validation mechanism, rejecting malformed Go-duration strings and ensuring
pipeline_timeout is at least the combined tasks and finally timeouts. Add tests
covering invalid formats and invalid cross-field combinations, while preserving
valid duration values.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 963fd724-6450-41bc-98fa-067047a4d2bd

📥 Commits

Reviewing files that changed from the base of the PR and between 8b3628e and 5851c8a.

📒 Files selected for processing (2)

• fournos/core/tekton.py
• fournos/settings.py

[kpouget]

/test deploy-fournos-wip

[kpouget]

/test deploy-fournos-wip

[kpouget]

    timeouts:
      finally: 1h0m0s
      pipeline: 25h0m0s
      tasks: 24h0m0s

test launched from Forge passed ✅

[albertoperdomo2]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albertoperdomo2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [albertoperdomo2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment