Skip to content

NO-JIRA: Fix some issues identified by yamllint#1174

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
hongkailiu:yamllint
Apr 14, 2025
Merged

NO-JIRA: Fix some issues identified by yamllint#1174
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
hongkailiu:yamllint

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Mar 27, 2025

See the rehearsal for the details.

The remained two will be fixed by https://github.com/openshift/cluster-version-operator/pull/1171/files#diff-d545314649981da131e9fa5eec88fd1fc37172eb51389689aa227464191bb133R72

$ yamllint -v && yamllint --strict -d '{extends: default, rules: {indentation: {indent-sequences: consistent}, document-start: disable, line-length: disable}}' ./install
yamllint 1.35.1
./install/0000_00_cluster-version-operator_03_deployment.yaml
  73:20     error    too many spaces inside braces  (braces)
  73:36     error    too many spaces inside braces  (braces)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

Details

In response to this:

The remained two will be fixed by https://github.com/openshift/cluster-version-operator/pull/1171/files#diff-d545314649981da131e9fa5eec88fd1fc37172eb51389689aa227464191bb133R72

$ yamllint --strict -d '{extends: default, rules: {indentation: {spaces: 2, indent-sequences: whatever}, document-start: disable, line-length: disable}}' ./install
./install/0000_00_cluster-version-operator_03_deployment.yaml
 73:22     error    too many spaces inside braces  (braces)
 73:38     error    too many spaces inside braces  (braces)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu
Copy link
Member Author

/test okd-scos-e2e-aws-ovn

@hongkailiu
Copy link
Member Author

/retest

2 similar comments
@hongkailiu
Copy link
Member Author

/retest

@hongkailiu
Copy link
Member Author

/retest

@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu
Copy link
Member Author

/retest

1 similar comment
@hongkailiu
Copy link
Member Author

/retest

@hongkailiu
Copy link
Member Author

/test e2e-agnostic-operator-devpreview

1 similar comment
@hongkailiu
Copy link
Member Author

/test e2e-agnostic-operator-devpreview

Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/label no-qe

@openshift-ci openshift-ci bot added the no-qe Allows PRs to merge without qe-approved label label Apr 14, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b247772 and 2 for PR HEAD d81848a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5524608 into openshift:main Apr 14, 2025
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.19.0-202504142210.p0.g5524608.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants