NO-JIRA: cvo: add test/verify-yaml#63274
NO-JIRA: cvo: add test/verify-yaml#63274openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
|
@hongkailiu: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@hongkailiu, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-yamllint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@hongkailiu, |
hongkailiu
force-pushed
the
cvo-yaml-lint
branch
from
4ed5a33 to
a560ee9
Compare
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-yamllint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@hongkailiu: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
hongkailiu
force-pushed
the
cvo-yaml-lint
branch
3 times, most recently
from
9310d75 to
4cb8f65
Compare
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-yamllint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/cc |
| cfg="$(mktemp)" | ||
| cat >"$cfg" <<EOF | ||
| extends: default | ||
| rules: | ||
| document-start: disable | ||
| line-length: disable | ||
| indentation: | ||
| indent-sequences: consistent | ||
| EOF | ||
| yamllint -v | ||
| yamllint --strict -c "$cfg" ./install |
There was a problem hiding this comment.
Can we do this in the repository hack/verify-yaml.sh script called a by a make verify, and just call that from here?
There was a problem hiding this comment.
hongkailiu
force-pushed
the
cvo-yaml-lint
branch
from
4cb8f65 to
6a395a7
Compare
hongkailiu
changed the title
hongkailiu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold Needs openshift/cluster-version-operator#1177 to do the rehearsal |
openshift-ci
bot
added
the
do-not-merge/hold
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-yaml |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-yaml |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-yaml |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-yaml |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-yaml |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse max |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
hongkailiu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci-robot
added
the
rehearsals-ack
|
@hongkailiu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5725567
into
openshift:master
5 participants
Need openshift/cluster-version-operator#1174 and openshift/cluster-version-operator#1171 to get in first.