-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-1057: CloudStorageLocation Prefix/CACert support #1126
OADP-1057: CloudStorageLocation Prefix/CACert support #1126
Conversation
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
Signed-off-by: Tiger Kaovilai <[email protected]>
ed96ab4
to
99b86dd
Compare
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
validated working :D |
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3a0ebef
to
38c3be6
Compare
Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
38c3be6
to
5cc5750
Compare
Signed-off-by: Tiger Kaovilai <[email protected]>
/retest |
2 similar comments
/retest |
/retest |
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
8bf081a
to
efd0d68
Compare
Signed-off-by: Tiger Kaovilai <[email protected]>
efd0d68
to
9451f3f
Compare
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/hold |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick oadp-1.2 |
@kaovilai: #1126 failed to apply on top of branch "oadp-1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* validator and type updates * validator and type updates Signed-off-by: Tiger Kaovilai <[email protected]> * CloudStorageLocation prefix is added to BSL * clarify backupImages error Signed-off-by: Tiger Kaovilai <[email protected]> * validator refactor returns err from validating funcs Signed-off-by: Tiger Kaovilai <[email protected]> * unit tests fix * simplify expression Signed-off-by: Tiger Kaovilai <[email protected]> * Add ignorable restore error logs and unit test Signed-off-by: Tiger Kaovilai <[email protected]> * consistent error string across bl.velero and bl.cloudstorage --------- Signed-off-by: Tiger Kaovilai <[email protected]>
* validator and type updates * validator and type updates * CloudStorageLocation prefix is added to BSL * clarify backupImages error * validator refactor returns err from validating funcs * unit tests fix * simplify expression * Add ignorable restore error logs and unit test * consistent error string across bl.velero and bl.cloudstorage --------- Signed-off-by: Tiger Kaovilai <[email protected]>
Related to openshift/openshift-velero-plugin#199
In order to avoid conflict with velero expected folders, new validations has been added.
Change Summary
Testing instructions
Prerequisites:
Substitute operator install steps in prerequiste for the following operator-sdk run command.
To try this patch, get operator-sdk and run
cleanup
After cleanup, you will have to create dpa again.
Example DPA
dev notes
bundle build command