-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-1057: AWS STS Creds support for internal image backup #199
OADP-1057: AWS STS Creds support for internal image backup #199
Conversation
Signed-off-by: Tiger Kaovilai <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: Tiger Kaovilai <[email protected]>
9cbdde9
to
a716260
Compare
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <[email protected]> remove pod backup plugin from main.go
… UID when copying Resolves ``` > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins: #0 4.584 error obtaining VCS status: exit status 128 #0 4.584 Use -buildvcs=false to disable VCS stamping. ``` Signed-off-by: Tiger Kaovilai <[email protected]>
0020d52
to
9fa8987
Compare
ab0d402
to
cf88caf
Compare
/test all |
Signed-off-by: Tiger Kaovilai <[email protected]>
cf88caf
to
adf11bd
Compare
Did some sanity testing. The changes work as intended. Marking ready for review. |
Signed-off-by: Tiger Kaovilai <[email protected]>
52739c6
to
5fa6472
Compare
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
w/ backupImages: true
|
/hold for 1.2.2 |
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kaovilai: This pull request references OADP-1057 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
/cherry-pick oadp-1.2 |
@kaovilai: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kaovilai: new pull request created: #202 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
⏯️ Testing instructions 🏈
TODO:
replace github.com/vmware-tanzu/velero v1.11.0 => github.com/kaovilai/velero v0000- // TODO: remove when https://github.com/openshift/velero/pull/279 is merged
oadp-1.2: Moving kopia logging to remove kopia from indirect dependency in vele… velero#279test image
dpa