Skip to content

NO-JIRA: cvo: add test/verify-yaml #63274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 13, 2025
Merged

NO-JIRA: cvo: add test/verify-yaml #63274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...or/config/openshift/cluster-version-operator/openshift-cluster-version-operator-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ base_images:
name: builder
namespace: ocp
tag: rhel-9-golang-1.23-openshift-4.19
yamllint:
name: rust
namespace: cincinnati-ci-public
tag: boot-root-1.79.0
Copy link
Member Author

@hongkailiu hongkailiu May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need both make and yamlint and this image happens to have both.
We may switch to a better/smaller one in the future.
For now, the image can do the job.

build_root:
from_repository: true
images:
Expand Down Expand Up @@ -171,6 +175,12 @@ tests:
CHECK_MOD_LIST: "false"
test:
- ref: go-verify-deps
- as: verify-yaml
commands: make verify-yaml
container:
clone: true
from: yamllint
run_if_changed: (\.yaml|\.yml)$
zz_generated_metadata:
branch: main
org: openshift
Expand Down
54 changes: 54 additions & 0 deletions ...penshift/cluster-version-operator/openshift-cluster-version-operator-main-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,3 +1211,57 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )verify-deps,?($|\s.*)
- agent: kubernetes
always_run: false
branches:
- ^main$
- ^main-
cluster: build06
context: ci/prow/verify-yaml
decorate: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-cluster-version-operator-main-verify-yaml
rerun_command: /test verify-yaml
run_if_changed: (\.yaml|\.yml)$
spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --report-credentials-file=/etc/report/credentials
- --target=verify-yaml
command:
- ci-operator
image: ci-operator:latest
imagePullPolicy: Always
name: ""
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )verify-yaml,?($|\s.*)