Moving kopia logging from util/logging to remove kopia from indirect dependency in velero plugins #277
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kaovilai
changed the title
|
This looks like a good change. We should post upstream too, and we can remove this commit when we pull it in from upstream. |
|
Ok |
kaovilai
force-pushed
the
unkopia-openshift-for-plugins
branch
from
889da9d
to
eef3a4d
Compare
|
Upstream PR vmware-tanzu#6484 |
…ro plugins when running `go mod why -m github.com/kopia/kopia` in velero-plugins prior to this change you will see following ``` ❯ go mod why -m github.com/kopia/kopia github.com/konveyor/openshift-velero-plugin/velero-plugins github.com/vmware-tanzu/velero/pkg/plugin/framework github.com/vmware-tanzu/velero/pkg/util/logging github.com/kopia/kopia/repo/logging ``` after ``` ❯ go mod why -m github.com/kopia/kopia (main module does not need module github.com/kopia/kopia) ``` Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
unkopia-openshift-for-plugins
branch
from
eef3a4d
to
13d6412
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cc @shawn-hurley @sseago @shubham-pampattiwar carry this cp? I wonder if upstream change will be cp to release-1.11 |
|
maybe create a 1.11 PR and see ? |
|
Lets pull this in now and if/when it's pulled into a 1.11.z release, we can drop it in favor of what's in the release. It may well be that 1.11.1 comes out before the change is pulled into 1.11 branch, so upstream may not get it until 1.11.2. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaovilai, sseago The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
closing due to vmware-tanzu#6484 merging. Will be cherrypicking from upstream. |
Unblocks OADP-1870
when running
go mod why -m github.com/kopia/kopiain velero-plugins prior to this change you will see followingafter
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.