Remove unused undercloud ctlplane_vip from scenario files#1424
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 2, 2026
Conversation
The undercloud ctlplane_vip was set in scenario files but never used by any service endpoint — they all use ctlplane_ip instead. The consumer in ci-framework's adoption_osp_deploy role has been removed in openstack-k8s-operators/ci-framework#4019. This removes the now-unnecessary ctlplane_vip key from the undercloud section in all 12 scenario files. The overcloud VIPs in vips_data.yaml files are unrelated and remain untouched. Depends-On: openstack-k8s-operators/ci-framework#4019 Related-Issue: #OSPRH-17418 Co-authored-by: Cursor <cursoragent@cursor.com>
ciecierski
added
the
check-before-merge/depends-on
hjensas
approved these changes
Jun 29, 2026
Contributor
|
/lgtm |
jistr
approved these changes
Jun 30, 2026
ciecierski
removed
the
check-before-merge/depends-on
Contributor
Author
|
depends-on ci-framework change is promoted to stable branch. change can be merged |
fyanac
approved these changes
Jul 2, 2026
Contributor
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciecierski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit ed3d943
into
openstack-k8s-operators:main
5 checks passed
Contributor
Author
|
/cherry-pick 18.0-fr6 |
|
@ciecierski: new pull request created: #1435 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctlplane_vipkey from theundercloud:section in all 12 scenario filesctlplane_vipwas never consumed by any service endpoint — all endpoints usectlplane_ipinsteadci-framework'sadoption_osp_deployrole is being removed in the companion PRThe overcloud VIPs defined in
vips_data.yamlfiles are a separate concept and are not affected by this change.Files changed
scenarios/hci.yaml,scenarios/uni01alpha.yaml,scenarios/uni02beta.yaml,scenarios/uni04delta.yaml,scenarios/uni04delta-ipv6.yaml,scenarios/uni05epsilon.yaml,scenarios/uni06zeta.yaml,scenarios/uni07eta.yaml,scenarios/uni09iota.yaml,scenarios/dcn_nostorage.yaml,scenarios/dcn_storage.yaml,scenarios/bgp-l3-xl.yamlTest plan
checkpipeline passes withDepends-Onpulling in the ci-framework companion PRDepends-On: openstack-k8s-operators/ci-framework#4019
Related-Issue: #OSPRH-17418
Made with Cursor