[18.0-fr6] Remove unused undercloud ctlplane_vip from scenario files#1435
Conversation
The undercloud ctlplane_vip was set in scenario files but never used by any service endpoint — they all use ctlplane_ip instead. The consumer in ci-framework's adoption_osp_deploy role has been removed in openstack-k8s-operators/ci-framework#4019. This removes the now-unnecessary ctlplane_vip key from the undercloud section in all 12 scenario files. The overcloud VIPs in vips_data.yaml files are unrelated and remain untouched. Depends-On: openstack-k8s-operators/ci-framework#4019 Related-Issue: #OSPRH-17418 Co-authored-by: Cursor <cursoragent@cursor.com>
|
/lgtm |
|
Actually i wonder if we want to give some time before merging to promote the ci-framework change into stable branch. If we merge this before then, it might block data-plane-adoption repo fr6->downstream promotion until ci-framework is promoted. |
|
ci-framework was promoted yesterday and has depends-on ci-framework change |
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
jistr
left a comment
jistr
left a comment
There was a problem hiding this comment.
Ah excellent, re-approving :)
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jistr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
recheck |
openshift-merge-bot
Bot
merged commit b94775b
into
openstack-k8s-operators:18.0-fr6
3 participants
This is an automated cherry-pick of #1424
/assign ciecierski