Skip to content

Conversation

@RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Oct 16, 2025

@RoyEJohnson RoyEJohnson requested a review from a team as a code owner October 16, 2025 17:57
@RoyEJohnson RoyEJohnson requested a review from Dantemss October 16, 2025 17:57
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-exx3r0 October 16, 2025 17:57 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from c960db6 to eb2267e Compare October 16, 2025 18:06
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 16, 2025 18:06 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 16, 2025 18:57 Inactive
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really what is needed to implement what is in the card? The card is just confusing to me and talks about a bunch of different things.

@RoyEJohnson RoyEJohnson marked this pull request as draft October 16, 2025 20:54
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 16, 2025 21:19 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from 7c665b9 to 95a8381 Compare October 16, 2025 21:34
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 16, 2025 21:34 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch 2 times, most recently from 9ec69a8 to 1b5aca0 Compare October 20, 2025 19:08
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 20, 2025 19:26 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from 1b5aca0 to 28a174b Compare October 22, 2025 21:28
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 22, 2025 21:29 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 22, 2025 21:34 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 14:28 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from 6aa8611 to af88dfe Compare October 23, 2025 14:41
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 14:41 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from af88dfe to 51c2df7 Compare October 23, 2025 15:08
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 15:08 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from 51c2df7 to ca1d517 Compare October 23, 2025 17:37
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 17:37 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from ca1d517 to 8af5ad9 Compare October 23, 2025 17:46
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 17:47 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 22:20 Inactive
Update CardWrapper.tsx
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from e45681f to 60e3ace Compare October 23, 2025 22:24
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 22:24 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from 60e3ace to e3de7c4 Compare October 23, 2025 23:30
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 23:31 Inactive
@RoyEJohnson RoyEJohnson force-pushed the core-20-fix-clear-highlight-when-user-moves-focus branch from e3de7c4 to df6cbaa Compare October 23, 2025 23:39
@TomWoodward TomWoodward temporarily deployed to rex-web-core-20-fix-cle-vlin1j October 23, 2025 23:39 Inactive
@RoyEJohnson RoyEJohnson marked this pull request as ready for review October 24, 2025 15:50
@RoyEJohnson RoyEJohnson requested a review from Dantemss October 24, 2025 18:28
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoyEJohnson in prod when I select text I get the highlights popup
In this heroku deployment when I select text I get the new popup telling me to press enter or click to edit the highlight.

Is this intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants