Always handles Shift+[1-9] for Associated Phrases. #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift+[1-9] keys were not handled when Shift+Enter was disabled for associated phrases. With the v2 associated phrases always prompting when such phrases are available, those keys need to be handled.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where Shift+[1-9] keys were not being handled for associated phrases when the Shift+Enter feature was disabled. With v2 associated phrases always prompting when available, these selection keys need to be handled regardless of the Shift+Enter configuration setting.
- Removes the dependency on
config_.shiftEnterEnabled.value()from the Shift key handling logic - Updates the comment to accurately reflect all three conditions that trigger Shift key handling
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The change correctly enables Shift+[1-9] key handling for associated phrases, aligning with the PR's goal. However, this change also brings a pre-existing bug with space key handling to the forefront, which I've detailed in a specific comment. Addressing this would significantly improve the user experience for the v2 associated phrases feature.
zonble
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift+[1-9] keys were not handled when Shift+Enter was disabled for associated phrases. With the v2 associated phrases always prompting when such phrases are available, those keys need to be handled.