Skip to content

Always handles Shift+[1-9] for Associated Phrases. #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonble merged 1 commit into from
Dec 18, 2025
Merged

Always handles Shift+[1-9] for Associated Phrases. #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/McBopomofo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,10 +808,9 @@ bool McBopomofoEngine::handleCandidateKeyEvent(

bool shouldUseShiftKey =
associatedPhrasesPlain != nullptr ||
(associatedPhrases != nullptr && associatedPhrases->useShiftKey &&
config_.shiftEnterEnabled.value());
(associatedPhrases != nullptr && associatedPhrases->useShiftKey);

// Plain Bopomofo and Associated Phrases.
// Plain Bopomofo, Associated Phrases, and Number Input.
if (shouldUseShiftKey || numberInput != nullptr) {
int code = origKey.code();
// Shift-[1-9] keys can only be checked via raw key codes. The Key objects
Expand Down