[chores] Updated tldextract and made ROOT_DOMAIN logic consistent #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
added this to In progress
in OpenWISP Priorities for next releases
via automation
A variable called ROOT_DOMAIN was computed with different methods in nginx and base image. The approach using the tldextract library seems more robust, therefore I decided to update the library and change the base image settings code accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variable called ROOT_DOMAIN was computed with different methods in nginx and base image.
The approach using the tldextract library seems more robust, therefore I decided to update the library and change the base image settings code accordingly.
Closes #281
Closes #273