Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chores] Updated tldextract and made ROOT_DOMAIN logic consistent #300

Merged
merged 2 commits into from
May 22, 2024
Merged

[chores] Updated tldextract and made ROOT_DOMAIN logic consistent #300

merged 2 commits into from
May 22, 2024

Commits on May 22, 2024

  1. [chores] Updated tldextract and made ROOT_DOMAIN logic consistent 

    A variable called ROOT_DOMAIN was computed with different
methods in nginx and base image.
The approach using the tldextract library seems more robust,
therefore I decided to update the library and change the
base image settings code accordingly.
    @nemesifier
    nemesifier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8fddac4 View commit details
    Browse the repository at this point in the history

  2. [ci] Fix python docker library requests 2.32.0 issue 

    See docker/docker-py#3256
    @nemesifier
    nemesifier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8caab55 View commit details
    Browse the repository at this point in the history