-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mwan3: fix grep order for nping track method #24859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the following commits to this PR:
CI/CD is still not happy! I think the name in your git config (your commit name) and your name in the Signed-off-by line is not the same. |
@ealdaz-seesai I think something has gone wrong during rebase! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have now 4 commits! And the PKG_RELEASE is still not updated.
Please look at this again.
Hi Florian
I’m going to get someone to help me with this asap. I’m not much of a git ninja.
Eduardo
…---
Eduardo Aldaz Carroll
CTO
sees.ai
E: ***@***.***
M: +44 (0) 7543 519191
On 4 Sep 2024, at 07:44, Florian Eckert ***@***.***> wrote:
@feckert requested changes on this pull request.
We have now 4 commits! And the PKG_RELEASE is still not updated.
—
Reply to this email directly, view it on GitHub <#24859 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIQJYAVHVVYWPBH6ZFKXL3DZU2T3ZAVCNFSM6AAAAABM4LGDDKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZZGEZTEMJQHA>.
You are receiving this because you were mentioned.
|
7a520b7
to
b3cdfac
Compare
Signed-off-by: Eduardo Aldaz-Carroll <[email protected]>
b3cdfac
to
976a739
Compare
Bumped up versions and changed author. |
Thanks merged! |
The grep parameters in the nping test appear to be in the wrong order. grep expects pattern and then filename.
Run tested:
Description:
Setting nping as a track_method option in /etc/config/mwan3 would always result in the interface failing all checks and becoming offline.
Changing the line in mwan3track
result=$(grep $TRACK_OUTPUT Lost | awk '{print $12}')
to
result=$(grep Lost $TRACK_OUTPUT | awk '{print $12}')
results in mwan3tracking behaving as expected, and the interface is correctly identified as being online.