Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delay between render tests #1938

Closed
wants to merge 1 commit into from
Closed

Add delay between render tests #1938

wants to merge 1 commit into from

Conversation

VadimKovalenkoSNF
Copy link
Collaborator

Fixes #1937

@VadimKovalenkoSNF
Copy link
Collaborator Author

Tests will fail till https://en.wikipedia.org/w/api.php?action=visualeditor&mobileformat=html&format=json&paction=parse&formatversion=2&page=MediaWiki%3ASidebar is unblocked.

@VadimKovalenkoSNF VadimKovalenkoSNF marked this pull request as ready for review October 31, 2023 06:22
kelson42
kelson42 requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@kelson42 kelson42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put test only related stuff in the software codebase. Create a test/const.ts.

I also don't understand why you don't play with the speed factor?

Secure CI is green (should be right?).

@kelson42
Copy link
Collaborator

kelson42 commented Nov 7, 2023

I guess the bug is going to be fixed upstream, so should we not close this PR?

@VadimKovalenkoSNF
Copy link
Collaborator Author

VadimKovalenkoSNF commented Nov 7, 2023 •
edited
Loading

I guess the bug is going to be fixed upstream, so should we not close this PR?

@kelson42 , yes, please close it.

@kelson42 kelson42 closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelson42 kelson42 kelson42 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REGRESSION] Renderer tests should have a delay between each invocation.
2 participants
@VadimKovalenkoSNF @kelson42