Add delay between render tests

src/util/const.ts

@@ -21,3 +21,4 @@ export const WEBP_HANDLER_URL = 'https://gist.githubusercontent.com/rgaudin/60bb
 export const MAX_FILE_DOWNLOAD_RETRIES = 5
 export const BLACKLISTED_NS = ['Story'] // 'Story' Wikipedia namespace is content, but not indgestable by Parsoid https://github.com/openzim/mwoffliner/issues/1853
 export const RENDERERS_LIST = ['WikimediaDesktop', 'VisualEditor', 'WikimediaMobile']
+export const RENDER_TEST_DELAY = 1000

test/e2e/extra.e2e.test.ts

@@ -5,7 +5,8 @@ import { join } from 'path'
 import { execa } from 'execa'
 import 'dotenv/config.js'
 import { jest } from '@jest/globals'
-import { RENDERERS_LIST } from '../../src/util/const.js'
+import { sleep } from '../util.js'
+import { RENDERERS_LIST, RENDER_TEST_DELAY } from '../../src/util/const.js'
 
 jest.setTimeout(20000)
 
@@ -67,6 +68,7 @@ describe('Extra', () => {
       const redisScan = await execa('redis-cli --scan', { shell: true })
       // Redis has been cleared
       expect(redisScan.stdout).toEqual('')
+      await sleep(RENDER_TEST_DELAY)
     })
   }
 })

test/testAllRenders.ts

@@ -1,8 +1,8 @@
 import * as logger from '../src/Logger.js'
 import * as mwoffliner from '../src/mwoffliner.lib.js'
 import { execa } from 'execa'
-import { RENDERERS_LIST } from '../src/util/const.js'
-import { zimcheckAvailable, zimdumpAvailable } from './util.js'
+import { RENDERERS_LIST, RENDER_TEST_DELAY } from '../src/util/const.js'
+import { zimcheckAvailable, zimdumpAvailable, sleep } from './util.js'
 
 interface Parameters {
   mwUrl: string
@@ -56,5 +56,6 @@ export async function testAllRenders(parameters: Parameters, callback) {
     outFiles[0].testId = testId
     outFiles[0].renderer = renderer
     await callback(outFiles)
+    await sleep(RENDER_TEST_DELAY)
   }
 }

test/unit/downloader.test.ts

@@ -17,7 +17,8 @@ import domino from 'domino'
 import { WikimediaDesktopRenderer } from '../../src/renderers/wikimedia-desktop.renderer.js'
 import { VisualEditorRenderer } from '../../src/renderers/visual-editor.renderer.js'
 import { WikimediaMobileRenderer } from '../../src/renderers/wikimedia-mobile.renderer.js'
-import { RENDERERS_LIST } from '../../src/util/const.js'
+import { RENDERERS_LIST, RENDER_TEST_DELAY } from '../../src/util/const.js'
+import { sleep } from '../util.js'
 
 jest.setTimeout(200000)
 
@@ -187,29 +188,6 @@ describe('Downloader class', () => {
       )
       expect(PaginatedArticle.length).toBeGreaterThan(100)
     })
-
-    test('getArticle response status for non-existent article id is 404 for WikimediaDesktop render', async () => {
-      const articleId = 'NeverExistingArticle'
-      const articleUrl = getArticleUrl(downloader, dump, articleId)
-      const articleDetail = {
-        title: articleId,
-        missing: '',
-      }
-      const _moduleDependencies = await downloader.getModuleDependencies(articleDetail.title)
-      await expect(
-        downloader.getArticle(
-          downloader.webp,
-          _moduleDependencies,
-          'NeverExistingArticle',
-          RedisStore.articleDetailXId,
-          wikimediaDesktopRenderer,
-          articleUrl,
-          dump,
-          articleDetail,
-          dump.isMainPage(articleId),
-        ),
-      ).rejects.toThrowError(new Error('Request failed with status code 404'))
-    })
   })
 
   describe('getArticle method', () => {
@@ -255,6 +233,7 @@ describe('Downloader class', () => {
             dump.isMainPage(articleId),
           ),
         ).rejects.toThrowError(new Error('Request failed with status code 404'))
+        await sleep(RENDER_TEST_DELAY)
       })
     }
   })

test/unit/saveArticles.test.ts

@@ -2,7 +2,7 @@ import domino from 'domino'
 
 import RedisStore from '../../src/RedisStore.js'
 import { startRedis, stopRedis } from './bootstrap.js'
-import { setupScrapeClasses } from '../util.js'
+import { setupScrapeClasses, sleep } from '../util.js'
 import { saveArticles } from '../../src/util/saveArticles.js'
 import { ZimArticle } from '@openzim/libzim'
 import { mwRetToArticleDetail, DELETED_ARTICLE_ERROR } from '../../src/util/index.js'
@@ -11,7 +11,7 @@ import { getArticleUrl } from '../../src/util/saveArticles.js'
 import { WikimediaDesktopRenderer } from '../../src/renderers/wikimedia-desktop.renderer.js'
 import { VisualEditorRenderer } from '../../src/renderers/visual-editor.renderer.js'
 import { WikimediaMobileRenderer } from '../../src/renderers/wikimedia-mobile.renderer.js'
-import { RENDERERS_LIST } from '../../src/util/const.js'
+import { RENDERERS_LIST, RENDER_TEST_DELAY } from '../../src/util/const.js'
 
 jest.setTimeout(40000)
 
@@ -87,6 +87,7 @@ describe('saveArticles', () => {
       expect(articleDoc.querySelector('meta[name="geo.position"]')?.getAttribute('content')).toEqual('51.50722222;-0.1275')
       // Check if header exists
       expect(articleDoc.querySelector('h1.article-header, h1.pcs-edit-section-title')).toBeTruthy()
+      await sleep(RENDER_TEST_DELAY)
     })
 
     test(`Check nodet article for en.wikipedia.org using ${renderer} renderer`, async () => {
@@ -118,6 +119,7 @@ describe('saveArticles', () => {
       const leadSection = sections[0]
       expect(sections.length).toEqual(1)
       expect(leadSection.getAttribute('data-mw-section-id')).toEqual('0')
+      await sleep(RENDER_TEST_DELAY)
     })
 
     test(`Load main page and check that it is without header using ${renderer} renderer`, async () => {
@@ -144,6 +146,7 @@ describe('saveArticles', () => {
       )
       const articleDoc = domino.createDocument(result[0].html)
       expect(articleDoc.querySelector('h1.article-header')).toBeFalsy()
+      await sleep(RENDER_TEST_DELAY)
     })
 
     test(`--customFlavour using ${renderer} renderer`, async () => {
@@ -211,6 +214,7 @@ describe('saveArticles', () => {
       expect(ParisDocument.querySelector('#PRE_PROCESSOR')).toBeDefined()
       // Prague was correctly post-processed
       expect(PragueDocument.querySelector('#POST_PROCESSOR')).toBeDefined()
+      await sleep(RENDER_TEST_DELAY)
     })
   }
 

test/unit/treatments/article.treatment.test.ts

@@ -2,15 +2,15 @@ import domino from 'domino'
 import RedisStore from '../../../src/RedisStore.js'
 import { ZimArticle } from '@openzim/libzim'
 import { mwRetToArticleDetail } from '../../../src/util/mw-api.js'
-import { setupScrapeClasses } from '../../util.js'
+import { setupScrapeClasses, sleep } from '../../util.js'
 import { startRedis, stopRedis } from '../bootstrap.js'
 import { saveArticles } from '../../../src/util/saveArticles.js'
 import { jest } from '@jest/globals'
 import { getArticleUrl } from '../../../src/util/saveArticles.js'
 import { WikimediaDesktopRenderer } from '../../../src/renderers/wikimedia-desktop.renderer.js'
 import { WikimediaMobileRenderer } from '../../../src/renderers/wikimedia-mobile.renderer.js'
 import { VisualEditorRenderer } from '../../../src/renderers/visual-editor.renderer.js'
-import { RENDERERS_LIST } from '../../../src/util/const.js'
+import { RENDERERS_LIST, RENDER_TEST_DELAY } from '../../../src/util/const.js'
 
 jest.setTimeout(10000)
 
@@ -91,6 +91,7 @@ describe('ArticleTreatment', () => {
       expect(articleDoc.querySelector('meta[name="geo.position"]')).toBeDefined()
       // Geo Position data is correct
       expect(articleDoc.querySelector('meta[name="geo.position"]')?.getAttribute('content')).toEqual('51.50722222;-0.1275')
+      await sleep(RENDER_TEST_DELAY)
     })
   }
 })