🐛 Wrap service account error to hide k8s error #1698
Merged
+87
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
+ Coverage 67.47% 68.02% +0.54%
==========================================
Files 59 59
Lines 5003 5004 +1
==========================================
+ Hits 3376 3404 +28
+ Misses 1380 1358 -22
+ Partials 247 242 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rashmi43
force-pushed
the
sa-does-not-exist
branch
from
8a24553 to
ff9cd88
Compare
rashmi43
force-pushed
the
sa-does-not-exist
branch
from
c06baaf to
2f9d96b
Compare
rashmi43
force-pushed
the
sa-does-not-exist
branch
from
cb16063 to
5729d8c
Compare
camilamacedo86
previously approved these changes
Feb 6, 2025
azych
reviewed
Feb 6, 2025
camilamacedo86
dismissed
their stale review
Lets address the latest nits raised first
rashmi43
force-pushed
the
sa-does-not-exist
branch
from
88054cb to
4e60ab7
Compare
camilamacedo86
approved these changes
Feb 7, 2025
Merged
via the queue into
operator-framework:main
with commit Feb 7, 2025
1af98d0
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap the service account not does not exist error message
Reviewer Checklist