[master] Enable Windows build. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mgruhler This is ready for review. Thanks! |
mgruhler
reviewed
Dec 13, 2019
There was a problem hiding this comment.
Thanks for this contribution @seanyen
I don't have any ROS Windows setup, so I cannot test any of this. But I'd be fine with merging if the ROS debian pkgs still behave the same.
I'll try to test this some time next week, but no guarantees ;-)
mgruhler
reviewed
Dec 13, 2019
This was referenced Jan 8, 2020
Closed
|
@seanyen I've just tested your changes and all seem fine. As discussed, I'll merge this now. Do you require a release or are your fine using this from source atm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is attempting to enable Windows build. This is verified against
https://aka.ms/rosproject.Dropped wildcard usage for
CMake -E copysince it is not really supported and not portable.Dropped
${CMAKE_SOURCE_DIR}fromlink_directoriesto make theCMakeLists.txtmore relocatable.Explicitly un-define
WIN32_LEAN_AND_MEAN, which is defined incatkinfor Windows build to avoid large namespace pollution. However, forSOEM, that makes many symbols (for example,timeBeginPeriod,malloc, andfree) invisible from Windows header, but which is required by source files (E.g.,osal.candoshw.c).