disk: AddPartitionsForBootMode() helper function (COMPOSER-2355) #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function that takes a partition table and adds partitions to satisfy the boot mode requirements: - BIOS/legacy: adds a 1 MiB BIOS boot partition. - UEFI: adds a 200 MiB EFI system partition. - Hybrid: adds both.
Define two new const strings: DosBIOSBootID and DosESPID, which are used for the BIOS boot and the EFI system partitions respectively on dos/mbr partition tables. In the new helper functions, use the partition table type to determine which ID to use. This means that the functions will return an error when the partition table type is not set (or is set to an unknown value).
achilleas-k
changed the title
mvo5
previously approved these changes
Nov 7, 2024
The previous error message was printing an invalid enum value as a string, which would cause a panic in the BootMode.String() method. Update the error in the AddPartitionsForBootMode() function and add a test.
achilleas-k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #926 which I'm slowly splitting into smaller, bite-sized PRs.
The PR introduces a helper function,
AddPartitionsForBootMode(). The function takes a partition table and boot mode and adds partitions to satisfy the boot mode requirements: