pkg: make seed in ImageType.Manifest() random by default
#1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the API of `ImageType.Manifest()` to take a pointer to the seed value. If no seed value is given it will automatically generate a random one. This avoid the pitfall that the consumer needs to know about properly seeding the manifests. The default use-case is to generate non-fixed seed manifests so this commit it easier.
|
This PR changes the images API or behaviour causing integration failures with osbuild-composer. The next update of the images dependency in osbuild-composer will need work to adapt to these changes. This is simply a notice. It will not block this PR from being merged. |
ondrejbudai
reviewed
Dec 13, 2024
achilleas-k
reviewed
Dec 13, 2024
Comment on lines
+125
to
+126
| // A custom seed for the rng can be specified, if nil the seed will | ||
| // be random. |
There was a problem hiding this comment.
Maybe we can be more accurate and informative here and say that it will be derived from the current time.
There was a problem hiding this comment.
Thanks! I'm happy to do that, I was thinking of using crypto.Rand to seed the generator but maybe I'm overthinking it. Happy to either document or change.
There was a problem hiding this comment.
Not important. Can do later or not at all.
mvo5
changed the title
seed in ImageType.Manifest() random by defaultseed in ImageType.Manifest() random by default
achilleas-k
approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
|
I prepared the followups to fix the consumers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the API of
ImageType.Manifest()to take a pointer to the seed value. If no seed value is given it will automatically generate a random one.This avoid the pitfall that the consumer needs to know about properly seeding the manifests. The default use-case is to generate non-fixed seed manifests so this commit makes it easier.
[edit: this is one possible way to avoid https://github.com/osbuild/image-builder-cli/pull/6#discussion_r1882807289]