rpmmd,dnfjson: add Path, RepoID to PackageSpec for librepo
#1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the two new `Path` and `RepoID` fields to the rpmmd.PackageSpec so that librepo can use them as it needs to correlate a package to a repo to generate the right mirror id. Ideally we would also make sure the inputs to manifest.Serialize() only accepts depsolved packageSets/repoConfigs via static type checking. There is a TODO for this now but it's not done in this commit as it requires some more thinking/discussion. But because of the strict requirement for matching packageSpec.RepoID and repoConfig.Id we should try to make this type safe. The repoConfig.Id is really only guranteed after the depsolve() run.
achilleas-k
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the two new
PathandRepoIDfields to the rpmmd.PackageSpec so that librepo can use them as it needs to correlate a package to a repo to generate the right mirror id.Ideally we would also make sure the inputs to manifest.Serialize() only accepts depsolved packageSets/repoConfigs via static type checking. There is a TODO for this now but it's not done in this commit as it requires some more thinking/discussion. But because of the strict requirement for matching packageSpec.RepoID and repoConfig.Id we should try to make this type safe. The repoConfig.Id is really only guranteed after the depsolve() run.
[split out from https://github.com//pull/1132 with improved docs/tests]