SW-4924: Replace tf_prefix by sensor_frame lidar_frame and imu_frame parameters #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Guillaume Doisy <[email protected]>
commit 6280bfa1178bdee4fe695cb4752efd5ff15279db Author: Ussama Naal <[email protected]> Date: Fri Apr 28 07:54:34 2023 -0700 Merge branch 'deprecate_tf_prefix' commit 35f2fd2 Author: Guillaume Doisy <[email protected]> Date: Mon Apr 3 18:12:44 2023 +0100 deprecate tf_prefix from os_cloud
|
Looks good to me |
Samahu
changed the title
kairenw
approved these changes
Apr 28, 2023
Samahu
deleted the
SW-4924-replace-tf-prefix-by-sensor-frame-lidar-frame-and-imu-frame-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
Summary of Changes
tf_prefixfrom os_cloud withsensor_frame,lidar_frameandimu_frameparameters.Validation
ros2 launch ouster_ros sensor.launch.xml sensor_hostname:=$SENSOR_HOSTNAMEros2 launch ouster_ros sensor.launch.xml sensor_hostname:=$SENSOR_HOSTNAME lidar_frame:=NEW_LIDAR_FRAME