Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS-196: laser scan from ros driver is not properly aligned with point cloud [ROS1] #224

Merged
merged 10 commits into from
Nov 29, 2023
Merged

ROS-196: laser scan from ros driver is not properly aligned with point cloud [ROS1] #224

merged 10 commits into from
Nov 29, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Sep 29, 2023 •
edited

Related Issues & PRs

Summary of Changes

  • Apply destagger to LaserScan message
  • Add LaserScan object to RVIZ
  • Fix an issue where LaserScan does not work properly with using dual mode
  • Address an issue where LaserScan appeared different on FW prior to 2.4

Validation

  • Make sure that the PointCloud and LaserScan fully aligned

@Samahu Samahu added the enhancement New feature or request label Sep 29, 2023
@Samahu Samahu self-assigned this Sep 29, 2023
@Samahu Samahu changed the title ROS-196: laser scan from ros driver is not properly aligned with point cloud humble ROS-196: laser scan from ros driver is not properly aligned with point cloud Sep 29, 2023
@Samahu Samahu force-pushed the ROS-196-laser-scan-from-ros-driver-is-not-properly-aligned-with-point-cloud-ros1 branch from 4392619 to 9c823b7 Compare November 22, 2023 22:03
@Samahu Samahu added the bug Something isn't working label Nov 22, 2023
This was referenced Nov 22, 2023
Merged
Merged
@Samahu Samahu changed the title ROS-196: laser scan from ros driver is not properly aligned with point cloud ROS-196: laser scan from ros driver is not properly aligned with point cloud [ROS1] Nov 22, 2023
@Samahu Samahu marked this pull request as ready for review November 23, 2023 02:30
@Samahu Samahu marked this pull request as draft November 23, 2023 16:58
@Samahu Samahu marked this pull request as ready for review November 23, 2023 20:05
@Samahu Samahu mentioned this pull request Nov 23, 2023
Closed
@Samahu Samahu merged commit 5a08f89 into master Nov 29, 2023
1 check passed
@Samahu Samahu deleted the ROS-196-laser-scan-from-ros-driver-is-not-properly-aligned-with-point-cloud-ros1 branch November 29, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twslankard twslankard twslankard approved these changes

@celentes celentes Awaiting requested review from celentes

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

@mtswisher mtswisher Awaiting requested review from mtswisher

Assignees

@Samahu Samahu

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with ouster/scan topic
2 participants
@Samahu @twslankard