Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnection behavior #233

Closed

Conversation

lowellausen
Copy link

Related Issues & PRs

This same reconnection behavior for ROS1: #119
The issue it started from: #55

Summary of Changes

Idea adapted to ROS2 from this PR: #119

Added reconnection behavior

  • New retry_configuration parameter that sets if we want to use the new reconnection behavior or not. Initially I've defaulted it to false as not to change current behavior automatically, ideas?
  • Makes config an attribute so we can reuse it in the connection loop
  • Adds logic to the configure_sensor() and to connection_loop() methods so that we can retry to configure the sensor
  • [QUESTIONABLE CHANGE MARK] Added throttling to the logs that come when trying to reconnect, to avoid the consequent spamming

Validation

  • Starting the system with sensor and/or ethernet cable disconnected
    • If retry_configuration
      • Driver will keep trying to configure the sensor until it's connected
      • Logs are throttled
    • Else
      • Same behavior as before: driver will fail to configure the sensor and stop trying
  • Same if the sensor is disconnected during runtime after it's already been configured

@Samahu
Copy link
Contributor

Samahu commented Aug 31, 2024

included/resolved by #362

@Samahu Samahu closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants