SW-5466: Support Velodyne point type in the ROS driver amendments #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note to changlog about the breaking change for ptp/utc time offset
twslankard
approved these changes
Nov 15, 2023
Samahu
deleted the
SW-5466-support-velodyne-point-type-in-the-ros-driver-follow-ups
branch
AchmadFathoni
pushed a commit
to AchmadFathoni/ouster-ros
that referenced
this pull request
Feb 16, 2024
…ster-lidar#254) * Add support to control point_type through launch.xml files + * Add a note to CHANGELOG about the breaking change for ptp/utc time offset
EirikKolas
added a commit
to vortexntnu/ouster-lidar-ros2-driver
that referenced
this pull request
Mar 23, 2024
* SW-5607: rename package ouster_msgs to avoid package name conflict in ros index (ouster-lidar#244) * rename package ouster_msgs to avoid conflict name conflict in ros index * set ouster_sensor_msgs version number to match with ouster_ros package * SW-5466: Support Velodyne and other point types in ouster-ros driver (ouster-lidar#216) * Quick protoype of Velodyne point type * Add PointXYZIR point type + other major pcl point types * Include point meta functions and point transform by the ouster_ros namesapce * Wrap point meta functions with a namespace and use shorter names for the functions + * Add a seed test module for the point_cloud_compose methods + Add description for the point_cloud_compose methods + refactor code and add compile time checks. * Propagate error state, warn about potential incompatible profile, propagate error state * Add minimal documentation about the new `point_type` parameter. * SW-5466: Support Velodyne point type in the ROS driver amendments (ouster-lidar#254) * Add support to control point_type through launch.xml files + * Add a note to CHANGELOG about the breaking change for ptp/utc time offset * SW-5623: Bump up ouster_client to 20231031 release (ouster-lidar#262) * Bump ouster-client to 2023103 release * fix: gracefully stop the driver when shutdown is requested. * ROS-196: laser scan from ros driver is not properly aligned with point cloud [humble] (ouster-lidar#203) * Apply destagger to laser scan + Add laser to RVIZ * Align LaserScan with the PointCloud * Apply proper pixel shift * Resolve the issue of zeroed laserscan on dual mode * Address an issue where LaserScan appeared different on FW prior to 2.4 * Fix the issue for odd numbers * List selected sensors on the main page + Update RVIZ config to highlight the 2D LaserScan. * Use timeout when waiting for packets to be proceed in case they don't come (ouster-lidar#293) * docs: fix spelling mistakes (ouster-lidar#296) --------- Co-authored-by: Ussama Naal <[email protected]> Co-authored-by: Andre Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
ptp_utc_tai_offsetdefault value #231 (adds a note to CHANGLOG.rst indicating that the default ptp_utc_tai_offset forms a breaking change).Summary of Changes
point_typethrough*.launch.xmlfilesValidation
Same steps to validate in #216 but utilize
*.launch.xmlformat to set thepoint_typeparameter.