Cmakelists: Fix install directories #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense but only concern is there were different dependencies (ROS packages) using the nonstd::optional library and they by default did the same thing, wouldn't they collide when installing to the same folder. |
ovaag
commented
Nov 16, 2023
Samahu
requested changes
Nov 17, 2023
This fixes issues when using install space
Co-authored-by: Ussama Naal <[email protected]>
ovaag
force-pushed
the
fix-install-dirs
branch
from
6a70438
to
a2c6cff
Compare
|
Rebased on latest master, increased package.xml minor version and added comment in changelog now. |
Samahu
approved these changes
Nov 19, 2023
tobii-ho
pushed a commit
to StarkStrom-Driverless/ouster-ros
that referenced
this pull request
Dec 27, 2023
* Add support for automatic UDP destination in simple_viz and ROS (ouster-lidar#255) * Add a read timeout for TCP sockets (ouster-lidar#258) * Fall back to ipv4 when ipv6 is disabled via kernel parameters (ouster-lidar#261) * Fix open3d example crash on macos (ouster-lidar#267)
tobii-ho
pushed a commit
to StarkStrom-Driverless/ouster-ros
that referenced
this pull request
Jan 23, 2024
* Add support for automatic UDP destination in simple_viz and ROS (ouster-lidar#255) * Add a read timeout for TCP sockets (ouster-lidar#258) * Fall back to ipv4 when ipv6 is disabled via kernel parameters (ouster-lidar#261) * Fix open3d example crash on macos (ouster-lidar#267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues of including headers from ouster_client or nonstd when using install space.
Folder layout on current master:
Note e.g.
os_point.hbeing located ininstall/include/ouster_ros/include/ouster_ros/os_point.hinstead of just
install/include/ouster_ros/os_point.hwhere I would expect it to be.How
install/includelooks after this PR:and so on..
This means that if you are using e.g.
staggerfunction fromlidar_scan.hin you own ros_pkg, you can now:Related Issues & PRs
Summary of Changes
Update install path in CmakeLists.txt
Validation
Included header from ouster_client and compiled with install space. It works!