Skip to content

tests: moved/added general tests to spec #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjherzog merged 2 commits into from
Oct 24, 2025
Merged

tests: moved/added general tests to spec #696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb4011
moved general tests to spec
jkowalleck Oct 1, 2025
a423a4b
Merge branch 'main' into tests/move-spec-tests-where-they-belong
mjherzog Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions tests/spec/specification-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,67 @@
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to build a PURL from invalid input components"
},
{
"description": "checks for invalid qualifier keys",
"test_group": "base",
"test_type": "parse",
"input": "pkg:npm/myartifact@1.0.0?in%20production=true",
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
},
{
"description": "checks for invalid qualifier keys",
"test_group": "base",
"test_type": "build",
"input": {
"type": "npm",
"namespace": null,
"name": "myartifact",
"version": "1.0.0",
"qualifiers": {
"in production": "true"
},
"subpath": null
},
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to build a PURL from invalid input components"
},
{
"description": "a name is required",
"test_group": "base",
"test_type": "parse",
"input": "pkg:maven/@1.3.4",
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
},
{
"description": "a name is required",
"test_group": "base",
"test_type": "build",
"input": {
"type": "maven",
"namespace": null,
"name": null,
"version": null,
"qualifiers": null,
"subpath": null
},
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to build a PURL from invalid input components"
},
{
"description": "invalid encoded colon : between scheme and type",
"test_group": "base",
"test_type": "parse",
"input": "pkg%3Amaven/org.apache.commons/io",
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
}
]
}
59 changes: 0 additions & 59 deletions tests/types/maven-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,40 +269,6 @@
"expected_failure": false,
"expected_failure_reason": null
},
{
"description": "a name is required",
Copy link
Member Author

@jkowalleck jkowalleck Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to specification-test

"test_group": "base",
"test_type": "parse",
"input": "pkg:maven/@1.3.4",
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
},
{
"description": "a name is required",
Copy link
Member Author

@jkowalleck jkowalleck Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to specification-test

"test_group": "base",
"test_type": "parse",
"input": "pkg:maven/@1.3.4",
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to parse a PURL from invalid canonical purl input"
},
{
"description": "a name is required",
"test_group": "base",
"test_type": "build",
"input": {
"type": "maven",
"namespace": null,
"name": null,
"version": null,
"qualifiers": null,
"subpath": null
},
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to build a PURL from invalid input components"
},
{
"description": "slash / after type is not significant. Roundtrip an input purl to canonical.",
"test_group": "advanced",
Expand Down Expand Up @@ -557,31 +523,6 @@
"expected_failure": false,
"expected_failure_reason": null
},
{
"description": "invalid encoded colon : between scheme and type",
"test_group": "base",
"test_type": "parse",
"input": "pkg%3Amaven/org.apache.commons/io",
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
},
{
"description": "invalid encoded colon : between scheme and type",
"test_group": "base",
"test_type": "build",
"input": {
"type": "maven",
"namespace": "org.apache.commons",
"name": "io",
"version": null,
"qualifiers": null,
"subpath": null
},
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to build a PURL from invalid input components"
},
{
"description": "Parse test for PURL type: maven",
"test_group": "base",
Expand Down
27 changes: 0 additions & 27 deletions tests/types/npm-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,33 +51,6 @@
"expected_failure": false,
"expected_failure_reason": null
},
{
Copy link
Member Author

@jkowalleck jkowalleck Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to specification-test

"description": "checks for invalid qualifier keys",
"test_group": "base",
"test_type": "parse",
"input": "pkg:npm/myartifact@1.0.0?in%20production=true",
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
},
{
"description": "checks for invalid qualifier keys",
Copy link
Member Author

@jkowalleck jkowalleck Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to specification-test

"test_group": "base",
"test_type": "build",
"input": {
"type": "npm",
"namespace": null,
"name": "myartifact",
"version": "1.0.0",
"qualifiers": {
"in production": "true"
},
"subpath": null
},
"expected_output": null,
"expected_failure": true,
"expected_failure_reason": "Should fail to build a PURL from invalid input components"
},
{
"description": "Parse test for PURL type: npm",
"test_group": "base",
Expand Down