Skip to content

Conversation

@nforro
Copy link
Member

@nforro nforro commented Jun 25, 2025

Pushing to a queue is pretty easy, question is how to deal with the opposite. I can see two options:

  • instructing the agent to pop from the queue, assign the data to predefined variables (named references) and then using those variables in place of current parameter expansions in further instructions
  • doing this outside of the agent and passing the data as parameters when starting the agent

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a job queue mechanism using Valkey and a new mcp-redis service. The changes update the Docker Compose setup, environment configuration, and Goose AI configuration to support this new functionality. A recipe is also updated to push jobs to the queue.

Comment on lines +143 to +147
REDIS_HOST=valkey
REDIS_PORT=6379
MCP_TRANSPORT=sse
MCP_HOST=0.0.0.0
MCP_PORT=8000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The environment variables MCP_TRANSPORT, MCP_HOST, and MCP_PORT are generic. Since multiple services load the same .env file, this can lead to configuration conflicts. It's recommended to namespace variables per service.

MCP_REDIS_TRANSPORT=sse
MCP_REDIS_HOST=0.0.0.0
MCP_REDIS_PORT=8000

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to change the variable names, the only way to separate them would be to introduce another env file.

mcp-redis:
depends_on:
- valkey
image: docker.io/mcp/redis:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the :latest tag for Docker images can lead to unexpected behavior. Pin to a specific version to ensure build reproducibility and stability.

    image: docker.io/mcp/redis:1.0.0 # Or another specific version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no named tags apart from latest, and I don't think it matters in this case.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could reference by digest redis@sha256:..... And then install renovate bot here to update the digest once there's a new image.

Signed-off-by: Nikola Forró <[email protected]>
@nforro
Copy link
Member Author

nforro commented Jun 26, 2025

  • instructing the agent to pop from the queue, assign the data to predefined variables (named references) and then using those variables in place of current parameter expansions in further instructions

I tried to implement this in b98508f. Something/someone still has to run the agents though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants