-
Notifications
You must be signed in to change notification settings - Fork 21
Add job queue #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add job queue #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a job queue mechanism using Valkey and a new mcp-redis service. The changes update the Docker Compose setup, environment configuration, and Goose AI configuration to support this new functionality. A recipe is also updated to push jobs to the queue.
| REDIS_HOST=valkey | ||
| REDIS_PORT=6379 | ||
| MCP_TRANSPORT=sse | ||
| MCP_HOST=0.0.0.0 | ||
| MCP_PORT=8000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible to change the variable names, the only way to separate them would be to introduce another env file.
| mcp-redis: | ||
| depends_on: | ||
| - valkey | ||
| image: docker.io/mcp/redis:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no named tags apart from latest, and I don't think it matters in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could reference by digest redis@sha256:..... And then install renovate bot here to update the digest once there's a new image.
Signed-off-by: Nikola Forró <[email protected]>
I tried to implement this in b98508f. Something/someone still has to run the agents though. |
Pushing to a queue is pretty easy, question is how to deal with the opposite. I can see two options: