Skip to content

Add job queue #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add job queue #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,26 @@ services:
command: ["--transport", "sse", "--port", "9000", "-vv"]
restart: unless-stopped

valkey:
image: docker.io/valkey/valkey:8
env_file:
- .env
volumes:
- valkey-data:/data
restart: unless-stopped

mcp-redis:
depends_on:
- valkey
image: docker.io/mcp/redis:latest
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the :latest tag for Docker images can lead to unexpected behavior. Pin to a specific version to ensure build reproducibility and stability.

    image: docker.io/mcp/redis:1.0.0 # Or another specific version

Copy link
Member Author

@nforro nforro Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no named tags apart from latest, and I don't think it matters in this case.

Copy link
Collaborator

@vrothberg vrothberg Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could reference by digest redis@sha256:..... And then install renovate bot here to update the digest once there's a new image.

env_file:
- .env
restart: unless-stopped

goose:
depends_on:
- mcp-atlassian
- mcp-redis
image: goose-container
build:
context: ./goose-container
Expand All @@ -28,3 +45,4 @@ services:

volumes:
home-goose-persistent:
valkey-data:
8 changes: 8 additions & 0 deletions env.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,3 +137,11 @@ PORT=9000
#CONFLUENCE_HTTPS_PROXY=https://confluence-proxy.example.com:8443
#CONFLUENCE_SOCKS_PROXY=socks5://confluence-proxy.example.com:1080
#CONFLUENCE_NO_PROXY=localhost,127.0.0.1,.internal.confluence.com


# Redis MCP
REDIS_HOST=valkey
REDIS_PORT=6379
MCP_TRANSPORT=sse
MCP_HOST=0.0.0.0
MCP_PORT=8000
Comment on lines +143 to +147
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The environment variables MCP_TRANSPORT, MCP_HOST, and MCP_PORT are generic. Since multiple services load the same .env file, this can lead to configuration conflicts. It's recommended to namespace variables per service.

MCP_REDIS_TRANSPORT=sse
MCP_REDIS_HOST=0.0.0.0
MCP_REDIS_PORT=8000

Copy link
Member Author

@nforro nforro Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to change the variable names, the only way to separate them would be to introduce another env file.

10 changes: 10 additions & 0 deletions goose-container/goose-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,13 @@ extensions:
timeout: 300
type: sse
uri: http://mcp-atlassian:9000/sse
redis:
bundled: null
description: null
enabled: true
env_keys: []
envs: {}
name: Redis MCP
timeout: 300
type: sse
uri: http://mcp-redis:8000/sse
4 changes: 4 additions & 0 deletions goose-recipes/issue-details.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ description: "Check details for issue {{ issue }}."

instructions: |
- Never create, delete, update or modify an Issue in Jira
- When passing a JSON object to a tool, ensure the entire object is formatted as a single string literal

parameters:
- key: issue
Expand All @@ -28,4 +29,7 @@ prompt: |
4. Identify the target branch `<git_branch>` of the `<package_name>` on GitLab to update. The branch information is usually related with the fixVersion Jira field. Verify the branch exists on GitLab.
* A fixVersion named rhel-N maps to a branch named cNs.

5. Push a new job to the left of the `rebase_queue` list as a JSON dictionary containing `<package_name>`,
`<package_version>`, `<git_branch>` and {{ issue }} as `jira_issue`.

Print the detected `<package_name>`, `<package_version>` and `<git_branch>` in a pretty list.