Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add item rarity to loot notifications for monsters #425

Merged
merged 15 commits into from
Feb 20, 2024

Conversation

@iProdigy iProdigy changed the title feat: add item rarity to loot notifications feat: add item rarity to loot notifications for monsters Feb 17, 2024
@iProdigy iProdigy marked this pull request as ready for review February 18, 2024 03:15
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to include the npc_drops.json source, both as a way for us to update it going forward & as a way to attribute the data

CHANGELOG.md Outdated Show resolved Hide resolved
@iProdigy
Copy link
Member Author

iProdigy commented Feb 18, 2024

Clarified data source in fb477f0

In particular, we feed their parsed data to our script to generate npc_drops.json - will eventually clean this up so it can be ran as an action to automatically update our json file

README.md Outdated Show resolved Hide resolved
@iProdigy iProdigy merged commit 5b09478 into pajlads:master Feb 20, 2024
4 checks passed
@iProdigy iProdigy deleted the feature/loot-rarity branch February 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants