Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setting to keep config synced with a custom URL #488

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jun 4, 2024

Closes #487 with a simplified implementation

@iProdigy iProdigy added the needs discussion Discussion is required on whether the requested feature should be added label Jun 4, 2024
@iProdigy
Copy link
Member Author

iProdigy commented Jun 4, 2024

open questions:

  • should ::dinkexport include the dynamic config url - probably yes
  • should ::dinkimport include the dynamic config url - probably yes
  • should there be a chat warning when a user modifies a notifier setting while a dynamic config url is specified (since on next restart, their change may be reverted depending on the contents of the url) - probably not initially worth the complexity

@iProdigy
Copy link
Member Author

iProdigy commented Jul 7, 2024

looks like there was another request for this
image

@iProdigy iProdigy marked this pull request as ready for review July 17, 2024 06:53
@iProdigy iProdigy removed the needs discussion Discussion is required on whether the requested feature should be added label Jul 17, 2024
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me, using ::dinkexport all it imported & merged webhook URLs as expected. I did not test if it can override the dynamic config URL

@iProdigy
Copy link
Member Author

i've tested that the dynamic url isn't overwritten :)

@iProdigy iProdigy merged commit 03ef0ab into pajlads:master Jul 20, 2024
4 checks passed
@iProdigy iProdigy deleted the feature/dynamic-config-url branch July 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API for endpoint to provide configuration
3 participants