Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Socket Options #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OriPekelman
Copy link

@OriPekelman OriPekelman commented Oct 18, 2021

Description

Correct socket_opts to socket_options

@OriPekelman
Copy link
Author

I did a quick github search of socket_opts vs socket_options in elixir projects and it is 10:1 for the latter, would you prefer me to do the PR "the other way around" ? (note that redis uses socket_opts so at any rate it will be slightly more consistent).

@@ -55,7 +55,7 @@ if config_env() === :prod do
http: [
port: port,
compress: true,
transport_options: [socket_opts: [:inet6]]
transport_options: [socket_options: [:inet6]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I don't think this is a valid configuration:

these expect socket_opts, not socket_options -- this code change probably just causes the configuration to ignore socket_opts completely, which may be why it fixes things on your end... I wonder if the better fix is to change this to socket_opts: socket_options (referencing the socket_options defined above on line 10 https://github.com/papercups-io/papercups/pull/988/files#diff-e43c5cbf91db7a8062b6cb860cbf118296c1b4c7ee32fdcf702e54234ba38092R10)

what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants