Correct Socket Options

[OriPekelman]

Description

Correct socket_opts to socket_options

[OriPekelman]

I did a quick github search of socket_opts vs socket_options in elixir projects and it is 10:1 for the latter, would you prefer me to do the PR "the other way around" ? (note that redis uses socket_opts so at any rate it will be slightly more consistent).

[reichert621]

hmm I don't think this is a valid configuration:

• http config uses Plug.Cowboy options: https://github.com/phoenixframework/phoenix/blob/master/lib/phoenix/endpoint.ex#L218-L220
• Options defined here: https://hexdocs.pm/plug_cowboy/Plug.Cowboy.html#module-options
• transport_options uses Ranch options: https://ninenines.eu/docs/en/ranch/1.7/manual/ranch/#_opts

these expect socket_opts, not socket_options -- this code change probably just causes the configuration to ignore socket_opts completely, which may be why it fixes things on your end... I wonder if the better fix is to change this to socket_opts: socket_options (referencing the socket_options defined above on line 10 https://github.com/papercups-io/papercups/pull/988/files#diff-e43c5cbf91db7a8062b6cb860cbf118296c1b4c7ee32fdcf702e54234ba38092R10)

what do you think?