Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Socket Options #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct Socket Options #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/runtime.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ if config_env() === :prod do
http: [
port: port,
compress: true,
transport_options: [socket_opts: [:inet6]]
transport_options: [socket_options: [:inet6]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I don't think this is a valid configuration:

these expect socket_opts, not socket_options -- this code change probably just causes the configuration to ignore socket_opts completely, which may be why it fixes things on your end... I wonder if the better fix is to change this to socket_opts: socket_options (referencing the socket_options defined above on line 10 https://github.com/papercups-io/papercups/pull/988/files#diff-e43c5cbf91db7a8062b6cb860cbf118296c1b4c7ee32fdcf702e54234ba38092R10)

what do you think?

],
url: [host: backend_url],
pubsub_server: ChatApi.PubSub,
Expand Down