fix: type safety and component props issues across TopNav and Dialog #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone through a few key components and made adjustments to improve type safety and proper prop forwarding:
TopNavContextTypeinterface and explicitly typedcreateContext<TopNavContextType>()to catch type errors when usingsetShow.classNamefrom the component and moved it to<a>to ensure props are correctly passed to the child.asChildand wrapped<svg>with<button>to match Radix's recommended Trigger structure.{width}and{height}as expressions for correct Next.js Image typing.changes fix type issues and ensure components behave correctly when using
asChildand TypeScript.