Skip to content

fix: type safety and component props issues across TopNav and Dialog #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: type safety and component props issues across TopNav and Dialog #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 42 additions & 35 deletions src/app/_components/TopNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,14 @@ import { ConnectModal } from "./ConnectModal";

import "./TopNav.css";

export const TopNavContext = createContext({
interface TopNavContextType {
show: boolean;
setShow: React.Dispatch<React.SetStateAction<boolean>>;
}

export const TopNavContext = createContext<TopNavContextType>({
show: false,
setShow: (_: boolean) => { },
setShow: () => {},
});

export function TopNavProvider({ children }: PropsWithChildren) {
Expand Down Expand Up @@ -53,16 +58,16 @@ export function TopNav() {
alt="Paradigm Logo"
className="h-[60px] ml-[-8px]"
src="/images/paradigm-transparent.svg"
width="153"
height="60"
width={153}
height={60}
/>
</div>
<div className="flex sm:hidden">
<Image
alt="Frontiers logo"
src="/images/frontiers.svg"
width="111"
height="25"
width={111}
height={25}
/>
</div>
<div className="absolute left-[50%] -translate-x-1/2 hidden sm:block">
Expand All @@ -78,56 +83,58 @@ export function TopNav() {
</Button>
</WithCursor>
</div>
<Dialog.Trigger className="sm:hidden">
<svg
width="24"
height="24"
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<title>Menu</title>
<path
d="M3 5H21M3 12H21M3 19H21"
stroke="white"
strokeWidth="1.5"
strokeLinecap="round"
strokeLinejoin="round"
/>
</svg>
<Dialog.Trigger asChild>
<button className="sm:hidden">
<svg
width="24"
height="24"
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<title>Menu</title>
<path
d="M3 5H21M3 12H21M3 19H21"
stroke="white"
strokeWidth="1.5"
strokeLinecap="round"
strokeLinejoin="round"
/>
</svg>
</button>
</Dialog.Trigger>
</div>
</div>
<Dialog.Content className="bg-black p-[32px] bg-opacity-90 border border-white border-opacity-20 animate-[0.1s_nav-enter_ease] rounded-[40px]">
<nav className="flex flex-col items-center gap-8">
<Text asChild fontFamily="typewriter" size="24">
<Dialog.Close asChild className="focus:outline-none">
<a href="#to-our-builders" className="no-underline text-white hover:opacity-80">MANIFESTO</a>
<Dialog.Close asChild>
<a href="#to-our-builders" className="focus:outline-none no-underline text-white hover:opacity-80">MANIFESTO</a>
</Dialog.Close>
</Text>
<Text asChild fontFamily="typewriter" size="24">
<Dialog.Close asChild className="focus:outline-none">
<a href="#agenda" className="no-underline text-white hover:opacity-80">AGENDA</a>
<Dialog.Close asChild>
<a href="#agenda" className="focus:outline-none no-underline text-white hover:opacity-80">AGENDA</a>
</Dialog.Close>
</Text>
<Text asChild fontFamily="typewriter" size="24">
<Dialog.Close asChild className="focus:outline-none">
<a href="#speakers" className="no-underline text-white hover:opacity-80">SPEAKERS</a>
<Dialog.Close asChild>
<a href="#speakers" className="focus:outline-none no-underline text-white hover:opacity-80">SPEAKERS</a>
</Dialog.Close>
</Text>
<Text asChild fontFamily="typewriter" size="24">
<Dialog.Close asChild className="focus:outline-none">
<a href="#faqs" className="no-underline text-white hover:opacity-80">FAQs</a>
<Dialog.Close asChild>
<a href="#faqs" className="focus:outline-none no-underline text-white hover:opacity-80">FAQs</a>
</Dialog.Close>
</Text>
<Text asChild fontFamily="typewriter" size="24">
<Dialog.Close asChild className="focus:outline-none">
<a href="#projects" className="no-underline text-white hover:opacity-80">OPEN SOURCE</a>
<Dialog.Close asChild>
<a href="#projects" className="focus:outline-none no-underline text-white hover:opacity-80">OPEN SOURCE</a>
</Dialog.Close>
</Text>
<Text asChild fontFamily="typewriter" size="24">
<Dialog.Close asChild className="focus:outline-none">
<a href="#pre-reads" className="no-underline text-white hover:opacity-80">PRE-READs</a>
<Dialog.Close asChild>
<a href="#pre-reads" className="focus:outline-none no-underline text-white hover:opacity-80">PRE-READs</a>
</Dialog.Close>
</Text>
</nav>
Expand Down