Omni-node: Manual-seal uses proper aura digests #9885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --audience runtime_dev runtime_user --bump major --force |
…time_dev runtime_user --bump major --force'
# Conflicts: # cumulus/polkadot-omni-node/lib/src/nodes/aura.rs
lexnv
reviewed
Oct 1, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd fmt |
|
Command "fmt" has failed ❌! See logs here |
iulianbarbu
reviewed
Oct 1, 2025
iulianbarbu
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we did not care about parachain slots in manual-seal mode, because para slots that are smaller than their relay parents where allowed. I have changes planned that change this, so the manual-seal needs to be parameterized closer to reality.
In this PR I use the
AuraConsensusDataproviderto read the inherent timestamp provided and emit a corresponding slot digest. I also removed theDynNodeSpecExtand added manual seal methods directly to theNodeSpectrait. The assumption before was that the manual seal mode can work independently of consensus information. But this no longer holds true, as we need the properAuraIdand runtime APIs attached for example. This was the fastest and simplest way to get this working, and we currently only supportAuraNodeanyway.closes #7453
Prerequisite for mergine #9712, as the old way we did things now causes errors.