Skip to content

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Oct 3, 2025

The std::fmt::Debug impl (derived) of Id results in "Id(42)" instead of "42", this causes discrepancies in logs. Sometimes we log "para_id=Id(3392)" but sometimes we log "para_id=3392" (without the "Id()").

This makes e.g. Grafana PromQL queries harder to do, and logs harder to search in general.

Example

Seen in e.g.:

Without ID(<ID>)

2025-09-22 22:28:06.753 DEBUG tokio-runtime-worker parachain::candidate-backing: Candidate backed candidate_hash=0x0cd77dd25cb61040557bb66df8de5c7b637dff05a671765b40bea7222cfa2854 relay_parent=0x7d380118542b6180127a150a86f144c448982c6af40da1dfb9e3119ad7d4c1ab para_id=3392 traceID=17069631741811285016642302447800179835

With ID(<ID>)

2025-09-22 22:28:06.342 DEBUG tokio-runtime-worker parachain::collator-protocol::stats: [Relaychain] Collation expired age=3 collation_state="fetched" relay_parent=0x7b394ee6c4fa2a3cec8fa82fa2afe5a933314e6a64e09256d7c8a28086b16acf para_id=Id(3392) head=0x92959b2b5fe8aba268bce48baf8a4e6b952055984015b8c1c7c3142c60e66e31

This PR changes the impl of Debug to be just "<ID>".

(Discussion on Matrix)

@Sajjon Sajjon added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Oct 3, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/18219750338
Failed job name: fmt

@Sajjon Sajjon added T17-primitives Changes to primitives that are not covered by any other label. and removed R0-no-crate-publish-required The change does not require any crates to be re-published. labels Oct 6, 2025
@Sajjon
Copy link
Contributor Author

Sajjon commented Oct 6, 2025

/cmd prdoc --audience node --bump patch

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Command "prdoc --audience node --bump patch" has failed ❌! See logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T17-primitives Changes to primitives that are not covered by any other label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants