Change Debug
of ParaId to"<ID>"
instead of "Id(<ID>)"
#9920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
std::fmt::Debug
impl (derived) ofId
results in"Id(42)"
instead of"42"
, this causes discrepancies in logs. Sometimes we log"para_id=Id(3392)"
but sometimes we log"para_id=3392"
(without the"Id()"
).This makes e.g. Grafana PromQL queries harder to do, and logs harder to search in general.
Example
Seen in e.g.:
Without
ID(<ID>)
With
ID(<ID>)
This PR changes the impl of
Debug
to be just"<ID>"
.(Discussion on Matrix)