Log consistency, use para_id= like everywhere else, instead of para=
#9921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajjon
added
the
R0-no-crate-publish-required
sandreim
approved these changes
Oct 3, 2025
alexggh
approved these changes
Oct 3, 2025
ggwpez
removed
the
R0-no-crate-publish-required
Member
|
You want the world to use this, so its not R0. |
Contributor
Author
|
/cmd prdoc --audience node --bump patch |
Contributor
|
Command "prdoc --audience node --bump patch" has failed ❌! See logs here |
Sajjon
deleted the
cyon/log_use_para_id_everywhere_instead_of_only_para
branch
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
…a=` (#9921) Follow up on #9920 (but can be reviewed / merged independently), I'm working on making it easier to query logs for events, specifically relating to specific parachains. We also incoherently sometimes use `"para="` and sometimes `"para_id=`", which also makes Grafana Queries harder to do: **All queries are done during 1 hour period** (2025-10-03 9:45-10:45 GMT) ## Parachain side: Query: `{chain="yap-kusama-3392"} |~ "para=""` gives 0 hits Query: `{chain="yap-kusama-3392"} |~ "para_id=""` gives 12k hits ## Relaychain side: Query: `{chain="kusama"} |~ "para="` gives 286k hits Query: `{chain="kusama"} |~ "para_id="` gives 99k hits # Changes I've changed so that we always use `para_id=` which is 3 chars longer but so clearer than `para=` (and with [my PR](#9920), we saved 4 chars `['I', 'd', '(', ')']`, so this is actually still net -1 char logged) All logs seem to come from [prospective-parachains/src/lib.rs](https://github.com/paritytech/polkadot-sdk/blob/bf235845f9ecb2b84264f255afd7aefdd5ddb603/polkadot/node/core/prospective-parachains/src/lib.rs#L797), using `para = ?`, which I've now changed to `para_id = ?` (Grafana (loki) query `{chain="kusama", subtarget!="prospective-parachains"} |= "para="` yield no results, i.e. all logged entries indeed come from `prospective-parachains` subtraget)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #9920 (but can be reviewed / merged independently), I'm working on making it easier to query logs for events, specifically relating to specific parachains.
We also incoherently sometimes use
"para="and sometimes"para_id=", which also makes Grafana Queries harder to do:All queries are done during 1 hour period (2025-10-03 9:45-10:45 GMT)
Parachain side:
Query:
{chain="yap-kusama-3392"} |~ "para=""gives 0 hitsQuery:
{chain="yap-kusama-3392"} |~ "para_id=""gives 12k hitsRelaychain side:
Query:
{chain="kusama"} |~ "para="gives 286k hitsQuery:
{chain="kusama"} |~ "para_id="gives 99k hitsChanges
I've changed so that we always use
para_id=which is 3 chars longer but so clearer thanpara=(and with my PR, we saved 4 chars['I', 'd', '(', ')'], so this is actually still net -1 char logged)All logs seem to come from prospective-parachains/src/lib.rs, using
para = ?, which I've now changed topara_id = ?(Grafana (loki) query
{chain="kusama", subtarget!="prospective-parachains"} |= "para="yield no results, i.e. all logged entries indeed come fromprospective-parachainssubtraget)