Skip to content

Log consistency, use para_id= like everywhere else, instead of para= #9921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+14 −4
Open

Log consistency, use para_id= like everywhere else, instead of para= #9921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
584dda2
Log consistency, use ``para_id=`` like everywhere else, instead of `p…
Sajjon Oct 3, 2025
cbe7091
dummy commit to resurrect ci
Sajjon Oct 6, 2025
a1f1df7
dummy commit to resurrect ci
Sajjon Oct 6, 2025
7e4496d
Add PRDoc
Sajjon Oct 7, 2025
c259c13
Fix PRDoc (white space issues)
Sajjon Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions polkadot/node/core/prospective-parachains/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ async fn handle_introduce_seconded_candidate(
Err(err) => {
gum::warn!(
target: LOG_TARGET,
para = ?para,
para_id = ?para,
"Cannot add seconded candidate: {}",
err
);
Expand Down Expand Up @@ -573,7 +573,7 @@ async fn handle_introduce_seconded_candidate(
if added.is_empty() {
gum::debug!(
target: LOG_TARGET,
para = ?para,
para_id = ?para,
candidate = ?candidate_hash,
"Newly-seconded candidate cannot be kept under any relay parent",
);
Expand Down Expand Up @@ -779,7 +779,7 @@ fn answer_hypothetical_membership_request(
Err(err) => {
gum::trace!(
target: LOG_TARGET,
para = ?para_id,
para_id = ?para_id,
leaf = ?active_leaf,
candidate = ?candidate.candidate_hash(),
"Candidate is not a hypothetical member on: {}",
Expand All @@ -794,7 +794,7 @@ fn answer_hypothetical_membership_request(
if membership.is_empty() {
gum::debug!(
target: LOG_TARGET,
para = ?candidate.candidate_para(),
para_id = ?candidate.candidate_para(),
active_leaves = ?view.active_leaves,
?required_active_leaf,
candidate = ?candidate.candidate_hash(),
Expand Down
10 changes: 10 additions & 0 deletions prdoc/pr_9921.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
title: 'Log consistency: use para_id= like everywhere else, instead of para='
doc:
- audience: Node Dev
description: |-
We incoherently sometimes use "para=" and sometimes "para_id=", this PR fixes that. This
makes it easier to follow the path of a parablock in logs, e.g. Loki (Grafana).

crates:
- name: polkadot-node-core-prospective-parachains
bump: patch
Loading