-
Notifications
You must be signed in to change notification settings - Fork 4
PMM-14365 New native PMM Navigation #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test Results: Note 1: |
|
@copilot Create a description of how hooks.js enables iframe in test suite and provide a quick insight into how much of a shortcut this is instead of doing it in every locator. |
🛠️ Implementation: Automated Grafana Iframe Handling (
|
| await locator.waitFor({ state: 'attached' }); | ||
| await locator.type(filterName); | ||
| await page.waitForTimeout(200); | ||
| await new Promise((resolve) => { setTimeout(resolve, 200); }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because before the test runs on the hook we change page to be handled as a frameLocator, so waitForTimeout doesn't exist in it, it was the only occurrence I could find on our tests, so I just changed the waitForTimeout to a nodejs sleep instead.
| I.fillField(this.fields.publicAddressInput, address); | ||
| I.click(this.fields.advancedButton); | ||
| I.verifyPopUpMessage(this.messages.successPopUpMessage); | ||
| I.refreshPage(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why refreshing of the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember, it was a fix for some failures on FB tests, I'll remove and retry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When removed, docker configuration fails consistently
https://github.com/percona/pmm-qa/actions/runs/20758328823/job/59819078766
| 'PMM-T2050 - Verify PostgreSQL Instance Summary Dashboard @nightly @dashboards', | ||
| async ({ I, dashboardPage }) => { | ||
| const { service_name } = await inventoryAPI.getServiceDetailsByStartsWithName('pdpgsql_pmm_'); | ||
| const { service_name } = await inventoryAPI.apiGetNodeInfoByServiceName(SERVICE_TYPE.POSTGRESQL, 'pdpgsql_pmm_', 'patroni'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With changes made to patroni the service chosen for checking the dashboard was being one of the patronis, and it had no data, so I changed it to exclude patroni and instead pickup the main service (I noticed the existence of another method that had this functionality so I just reused)
This change isn't related to new native, it was just a test bug that I fixed here, I can remove
Introduce a bootstrap hook for handling Grafana iframes in tests, fix issues related to the new UI, and implement general test improvements to enhance stability and performance.