fix(phel): align with phel-lang main — lazy-seq + ExceptionInfo rename#14
Merged
Merged
Conversation
Two phel test failures resolved by bumping to phel-lang main (post v0.38.0): - Lazy-seq tests (test-lazy-seq 'basics' in lazy_seq.cljc): rest/next now match Clojure semantics — (rest s) no longer forces head of tail, so (realized? (rest s)) stays false (phel-lang#1997) - add_watch.cljc catch-class updated from Phel.Lang.ExInfoException to Phel.Lang.ExceptionInfo, matching the Clojure-aligned rename in phel-lang#2006 composer.json pinned to "dev-main as 0.39.x-dev" until phel-lang/phel-lang cuts v0.39.0 (phel-lang#2011); switch to ^0.39 once tagged + published. Full suite: 4692 passed, 0 failed.
Phel was disabled together with basilisp in 72997e3 ("Disable every dialect except clj,cljr,cljs,bb"). Now that the lazy-seq and class-rename breakage is resolved (phel-lang/main and the changes in this PR), phel runs green (4692 passed, 0 failed). Re-enables only the phel matrix (basilisp stays commented until its parity work lands).
v0.39.0 (https://github.com/phel-lang/phel-lang/releases/tag/v0.39.0) bundles the lazy-seq fix (phel-lang#1997) and the ExInfoException → ExceptionInfo rename (phel-lang#2006). Drop the dev-main shim plus minimum-stability/prefer-stable now that a stable tag exists. Full suite: 4692 passed, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
phel-lang/phel-langto^0.39and align tests with upstream class renames.composer.json: pin^0.39(v0.39.0 ships lazy-seq fix #1997 + ExceptionInfo rename #2006)test/clojure/core_test/add_watch.cljc:Phel.Lang.ExInfoException→Phel.Lang.ExceptionInfo.github/workflows/ci.yml: re-enabletest-pheljob (PHP 8.4, 8.5)Test plan
composer test→ 4692 passed, 0 failed locallytest-phelgreen on 8.4 and 8.5