Skip to content

fix(phel): align with phel-lang main — lazy-seq + ExceptionInfo rename #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 3 commits into from
May 19, 2026
Merged

fix(phel): align with phel-lang main — lazy-seq + ExceptionInfo rename #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c974a44
fix(phel): pin phel-lang to dev-main and rename ExInfoException
Chemaclass May 19, 2026
300aa67
ci(phel): re-enable phel test job in CI
Chemaclass May 19, 2026
7728ad5
fix(phel): pin phel-lang ^0.39 now that v0.39.0 is released
Chemaclass May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,40 +170,40 @@ jobs:
# BASILISP_TEST_FILE_PATTERN='.*\.(lpy|cljc)' \
# basilisp test -p test -- -n 0

#test-phel:
# runs-on: ubuntu-latest
# strategy:
# fail-fast: false
# matrix:
# php: ['8.4', '8.5']
# steps:
# - uses: actions/checkout@v4
test-phel:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php: ['8.4', '8.5']
steps:
- uses: actions/checkout@v4

# - uses: shivammathur/setup-php@v2
# with:
# php-version: ${{ matrix.php }}
# coverage: none
# tools: composer
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
coverage: none
tools: composer

# - name: Cache Composer downloads
# uses: actions/cache@v4
# with:
# path: ~/.composer/cache
# key: composer-${{ matrix.php }}-${{ hashFiles('composer.lock') }}
# restore-keys: |
# composer-${{ matrix.php }}-
- name: Cache Composer downloads
uses: actions/cache@v4
with:
path: ~/.composer/cache
key: composer-${{ matrix.php }}-${{ hashFiles('composer.lock') }}
restore-keys: |
composer-${{ matrix.php }}-

# - name: Cache Phel compiled artifacts
# uses: actions/cache@v4
# with:
# path: .phel/cache
# key: phel-cache-${{ matrix.php }}-${{ hashFiles('composer.lock', 'phel-config.php') }}-${{ hashFiles('test/**/*.cljc', 'test/**/*.phel') }}
# restore-keys: |
# phel-cache-${{ matrix.php }}-${{ hashFiles('composer.lock', 'phel-config.php') }}-
# phel-cache-${{ matrix.php }}-
- name: Cache Phel compiled artifacts
uses: actions/cache@v4
with:
path: .phel/cache
key: phel-cache-${{ matrix.php }}-${{ hashFiles('composer.lock', 'phel-config.php') }}-${{ hashFiles('test/**/*.cljc', 'test/**/*.phel') }}
restore-keys: |
phel-cache-${{ matrix.php }}-${{ hashFiles('composer.lock', 'phel-config.php') }}-
phel-cache-${{ matrix.php }}-

# - name: Install dependencies
# run: composer install --no-interaction --no-ansi --no-progress
- name: Install dependencies
run: composer install --no-interaction --no-ansi --no-progress

# - name: Run tests
# run: composer test
- name: Run tests
run: composer test
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"require": {
"phel-lang/phel-lang": "^0.38"
"phel-lang/phel-lang": "^0.39"
},
"scripts": {
"test": "XDEBUG_MODE=off ./vendor/bin/phel test"
Expand Down
28 changes: 14 additions & 14 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/clojure/core_test/add_watch.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
:clj clojure.lang.ExceptionInfo
:cljr clojure.lang.ExceptionInfo
:lpy basilisp.lang.exception/ExceptionInfo
:phel Phel.Lang.ExInfoException) e
:phel Phel.Lang.ExceptionInfo) e
(let [data (ex-data e)]
(vswap! state conj data)))))]
(do-update a)
Expand Down
Loading